From: Jason Baron <jbaron@redhat.com>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: Hagen Paul Pfeifer <hagen@jauu.net>,
torvalds@linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH Resend] epoll: add EPOLLEXCLUSIVE support
Date: Wed, 28 Mar 2012 12:21:08 -0400 [thread overview]
Message-ID: <20120328162108.GB2381@redhat.com> (raw)
In-Reply-To: <CAFLxGvx0m6iaDPTDkjzw6ohX6Wdmr+DgWEr_fMdyEux50JVFEw@mail.gmail.com>
On Wed, Mar 28, 2012 at 04:09:24PM +0200, richard -rw- weinberger wrote:
> On Wed, Mar 28, 2012 at 3:57 PM, Hagen Paul Pfeifer <hagen@jauu.net> wrote:
> > High performance server sometimes create one listening socket (e.g. port
> > 80), create a epoll file descriptor and add the socket. Afterwards
> > create SC_NPROCESSORS_ONLN threads and wait for events. This often
> > result in a thundering herd problem because all CPUs are scheduled.
> >
> > This patch add an additional flag to epoll_ctl(2) called EPOLLEXCLUSIVE.
> > If a descriptor is added with this flag only one CPU is scheduled in.
> >
> > Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
> > ---
> > Dave rejected the patch and said not network specific. Because there
> > is no epoll maintainer this time directly.
>
> CC'ing maintainers for you...
> Please use scripts/get_maintainer.pl.
>
Hmmm...Looking at ep_poll() it does an '__add_wait_queue_exclusive()'.
So, I *think* epoll_wait() should do what you want, if you are waiting
on the same epfd in all the threads.
I think the case you are describing is where each thread does its own
ep_create(), and then a subsequent epoll_wait() on the fd from the
create?
So, I *think* you can get what you want without adding this flag.
Thanks,
-Jason
next prev parent reply other threads:[~2012-03-28 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1332943060-18374-1-git-send-email-hagen@jauu.net>
2012-03-28 14:09 ` [PATCH Resend] epoll: add EPOLLEXCLUSIVE support richard -rw- weinberger
2012-03-28 16:21 ` Jason Baron [this message]
2012-03-28 19:58 ` Hagen Paul Pfeifer
2012-03-29 14:16 ` Jason Baron
2012-03-29 15:05 ` Hagen Paul Pfeifer
2012-03-29 15:53 ` Jason Baron
2012-03-29 16:32 ` Hagen Paul Pfeifer
2012-03-29 18:54 ` Jason Baron
2012-03-29 21:19 ` Hagen Paul Pfeifer
2012-04-05 22:30 ` Andy Lutomirski
2012-03-29 14:51 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328162108.GB2381@redhat.com \
--to=jbaron@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hagen@jauu.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=richard.weinberger@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).