From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@infradead.org, mszeredi@suse.cz
Subject: Re: [PATCH 5/6] vfs: reorganize do_lookup
Date: Fri, 30 Mar 2012 20:05:26 +0100 [thread overview]
Message-ID: <20120330190526.GA29050@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1332759264-23533-6-git-send-email-miklos@szeredi.hu>
On Mon, Mar 26, 2012 at 12:54:23PM +0200, Miklos Szeredi wrote:
> This also eliminates the weird retry loop, that could, in theory, retry the
> cached lookup any number of times (very unlikely scenario: needs two parallel
> do_lookups and d_revalidate always returning zero).
That really needs to be carved into much smaller pieces - the sucker is
convoluted as hell and there's a lot of codepaths in there with nearly
zero test coverage. I've split it up into provably equivalent
transformations, leading more or less to the state where yours ends up.
I _think_ I've reconstructed the sequence of changes more or less
close to what you were doing there, but the next time you have to do
something of that kind, do not collapse that into a single patch. It's
really easier to review step by step...
Anyway, I'd put the whole thing into vfs.git#for-linus; see if you have
any problems with it.
next prev parent reply other threads:[~2012-03-30 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 10:54 [PATCH 0/6] vfs: path lookup fixes and cleanups Miklos Szeredi
2012-03-26 10:54 ` [PATCH 1/6] vfs: fix d_need_lookup/d_revalidate order in do_lookup Miklos Szeredi
2012-03-26 10:54 ` [PATCH 2/6] vfs: don't revalidate just looked up dentry Miklos Szeredi
2012-03-26 10:54 ` [PATCH 3/6] vfs: move MAY_EXEC check from __lookup_hash() Miklos Szeredi
2012-03-26 10:54 ` [PATCH 4/6] vfs: set LOOKUP_JUMPED in follow_managed Miklos Szeredi
2012-03-30 2:39 ` Al Viro
2012-03-26 10:54 ` [PATCH 5/6] vfs: reorganize do_lookup Miklos Szeredi
2012-03-30 19:05 ` Al Viro [this message]
2012-04-03 8:13 ` Miklos Szeredi
2012-04-04 3:16 ` Al Viro
2012-04-05 14:44 ` Miklos Szeredi
2012-03-26 10:54 ` [PATCH 6/6] vfs: split __lookup_hash Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330190526.GA29050@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).