From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Ts'o Subject: Re: [RFC PATCH v2 18/21] ext4: add support for read_iter and write_iter Date: Mon, 2 Apr 2012 11:42:04 -0700 Message-ID: <20120402184204.GE2880@thunk.org> References: <1333122228-13633-1-git-send-email-dave.kleikamp@oracle.com> <1333122228-13633-19-git-send-email-dave.kleikamp@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zach Brown , Andreas Dilger , linux-ext4@vger.kernel.org To: Dave Kleikamp Return-path: Content-Disposition: inline In-Reply-To: <1333122228-13633-19-git-send-email-dave.kleikamp@oracle.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Mar 30, 2012 at 10:43:45AM -0500, Dave Kleikamp wrote: > use the generic .read_iter and .write_iter functions Potentially silly question --- why not use NULL pointer to mean generic_file_read_iter and generic_file_write_iter? Then you won't have to patch a bunch of file systems to add the generic .read_iter and .write_iter? - Ted