linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@canonical.com>
To: Li Wang <liwang@nudt.edu.cn>
Cc: dustin.kirkland@gazzang.com, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] eCryptfs file system with HMAC verification
Date: Tue, 10 Apr 2012 11:05:34 -0500	[thread overview]
Message-ID: <20120410160534.GA3891@boyd> (raw)
In-Reply-To: <000a01cd171d$9e6c23b0$db446b10$@edu.cn>

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

On 2012-04-10 21:26:58, Li Wang wrote:
> Hi,
>   we have implemented a prototype, which equips eCryptfs with HMAC verification,
> based on the kernel crypto API. This enables eCryptfs to detect unauthorized (cipher) 
> data modification and unexpected data corruption. And the preliminary experiments 
> demonstrate the decrease in throughput is modest. As a file system highlighting security,
> we think it should be useful.
>   Any comments/suggestions are welcome.

Hi Li - the paragraph above does not give me much to comment on but what
I can say is that an HMAC patch for eCryptfs was written years ago.
Unfortunately, it seems to have been lost. I don't think that the patch
was ever sent to a list but it lived in the project's old sourceforge
site for a long time.

The maintainer of eCryptfs at that time was also the original author of
eCryptfs, Mike Halcrow, and he opted to not merge the HMAC patch in
favor of using GCM for integrity protection. The HMAC patch was at least
his own design and maybe his own code (I can't quite remember), so he
wasn't negatively biased when deciding that GCM would be a better fit.
Here's a reference, although it isn't the actual patch review:

http://www.mail-archive.com/ecryptfs-users@lists.sourceforge.net/msg00271.html

You can find more about Mike's HMAC design in the design doc located the
ecryptfs-utils source tree.

So, the best way to proceed is probably to ask if you've given GCM any
consideration?

Tyler

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-04-10 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <000a01cd171d$9e6c23b0$db446b10$@edu.cn>
2012-04-10 13:26 ` [RFC] eCryptfs file system with HMAC verification Li Wang
2012-04-10 13:26 ` Li Wang
2012-04-10 13:26 ` Li Wang
2012-04-10 16:05 ` Tyler Hicks [this message]
2012-04-10 13:22 Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120410160534.GA3891@boyd \
    --to=tyhicks@canonical.com \
    --cc=akpm@linux-foundation.org \
    --cc=dustin.kirkland@gazzang.com \
    --cc=ecryptfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwang@nudt.edu.cn \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).