From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
Chris Mason <chris.mason@oracle.com>,
Shaohua Li <shli@fusionio.com>
Subject: Re: [RESEND][PATCH v2] block: remove plugging at buffered write time
Date: Wed, 11 Apr 2012 16:13:44 -0700 [thread overview]
Message-ID: <20120411161344.309f12ef.akpm@linux-foundation.org> (raw)
In-Reply-To: <x494nst7z3v.fsf@segfault.boston.devel.redhat.com>
On Mon, 09 Apr 2012 10:34:44 -0400
Jeff Moyer <jmoyer@redhat.com> wrote:
> Wu Fengguang <fengguang.wu@intel.com> writes:
>
> > Buffered write(2) is not directly tied to IO, so it's not suitable to
> > handle plug in generic_file_aio_write().
> [snip, moved]
> > Note that plugging for O_SYNC writes is also removed. The user may pass
> > arbitrary @size arguments, which may be much larger than the preferable
> > I/O size, or may cross extent/device boundaries. Let the lower layers
> > handle the plugging. Otherwise the plugging code here will turn the
> > low level plugging into no-ops.
>
> I assume you have some numbers to back this up, right? Care to share
> those?
Yes please.
We've broken this stuff a few times recently - we should review and
test carefully.
> > Also moves unplugging for direct I/O from around ->direct_IO() down to
> > do_blockdev_direct_IO().
>
> This could be handled in a separate patch.
I think that would be better.
next prev parent reply other threads:[~2012-04-11 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 1:06 [RESEND][PATCH v2] block: remove plugging at buffered write time Wu Fengguang
2012-04-09 14:34 ` Jeff Moyer
2012-04-11 23:13 ` Andrew Morton [this message]
2012-04-12 1:32 ` Fengguang Wu
2012-04-12 2:20 ` Fengguang Wu
2012-04-12 14:26 ` Jan Kara
2012-04-13 1:40 ` Fengguang Wu
2012-05-03 3:43 ` [PATCH] btrfs: lower metadata writeback threshold on low dirty threshold Fengguang Wu
2012-05-03 3:53 ` [PATCH] writeback: initialize global_dirty_limit Fengguang Wu
2012-05-03 9:25 ` [PATCH] btrfs: lower metadata writeback threshold on low dirty threshold Jan Kara
2012-05-03 10:02 ` Fengguang Wu
2012-05-03 12:31 ` Chris Mason
2012-05-03 13:30 ` Josef Bacik
2012-05-03 14:08 ` Fengguang Wu
2012-05-06 6:01 ` [RESEND][PATCH v2] block: remove plugging at buffered write time Fengguang Wu
2012-05-06 9:58 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411161344.309f12ef.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fusionio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).