From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
viro@ZenIV.linux.org.uk
Subject: Re: [PATCH] fs: make i_generation a u64
Date: Wed, 11 Apr 2012 20:32:57 -0400 [thread overview]
Message-ID: <20120412003257.GH29506@shiny> (raw)
In-Reply-To: <1334176968-8687-1-git-send-email-josef@redhat.com>
On Wed, Apr 11, 2012 at 04:42:48PM -0400, Josef Bacik wrote:
> Btrfs stores generation numbers as 64bit numbers, which means we have to
> carry around a u64 in our incore inode in addition to setting i_generation.
> So convert to a u64 so btrfs can kill it's incore generation. Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
> ---
> include/linux/fs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 9be896d..40564e0 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -831,7 +831,7 @@ struct inode {
> struct cdev *i_cdev;
> };
>
> - __u32 i_generation;
> + u64 i_generation;
Why was this using __u32 instead of u32?
-chris
next prev parent reply other threads:[~2012-04-12 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 20:42 [PATCH] fs: make i_generation a u64 Josef Bacik
2012-04-12 0:32 ` Chris Mason [this message]
2012-04-12 6:46 ` Marco Stornelli
2012-04-12 13:20 ` Josef Bacik
2012-04-12 13:56 ` Josef Bacik
2012-04-12 19:42 ` Ted Ts'o
2012-04-12 19:49 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412003257.GH29506@shiny \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).