From: Jan Kara <jack@suse.cz>
To: Shaohua Li <shli@kernel.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu
Subject: Re: [RFC]jbd2: use GFP_NOFS for blkdev_issue_flush
Date: Tue, 17 Apr 2012 11:58:30 +0200 [thread overview]
Message-ID: <20120417095830.GE7198@quack.suse.cz> (raw)
In-Reply-To: <4F878F17.2030900@kernel.org>
On Fri 13-04-12 10:27:35, Shaohua Li wrote:
>
> flush request is issued in transaction commit code path, so looks using
> GFP_KERNEL to allocate memory for flush request bio falls into the classic
> deadlock issue. I saw btrfs and dm get it right, but ext4, xfs and md are
> using GFP_KERNEL, which makes me confused. Hoping filesystem developers
> clarify.
>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
Yeah, ext4 (jbd2) should use GFP_NOFS since we are in a kjournald and
reclaim could possibly need to start a transaction thus blocking on
kjournald. So you have my:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/commit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/fs/jbd2/commit.c
> ===================================================================
> --- linux.orig/fs/jbd2/commit.c 2012-04-13 09:57:51.785506925 +0800
> +++ linux/fs/jbd2/commit.c 2012-04-13 09:58:29.585498773 +0800
> @@ -723,7 +723,7 @@ start_journal_io:
> if (commit_transaction->t_need_data_flush &&
> (journal->j_fs_dev != journal->j_dev) &&
> (journal->j_flags & JBD2_BARRIER))
> - blkdev_issue_flush(journal->j_fs_dev, GFP_KERNEL, NULL);
> + blkdev_issue_flush(journal->j_fs_dev, GFP_NOFS, NULL);
>
> /* Done it all: now write the commit record asynchronously. */
> if (JBD2_HAS_INCOMPAT_FEATURE(journal,
> @@ -859,7 +859,7 @@ wait_for_iobuf:
> if (JBD2_HAS_INCOMPAT_FEATURE(journal,
> JBD2_FEATURE_INCOMPAT_ASYNC_COMMIT) &&
> journal->j_flags & JBD2_BARRIER) {
> - blkdev_issue_flush(journal->j_dev, GFP_KERNEL, NULL);
> + blkdev_issue_flush(journal->j_dev, GFP_NOFS, NULL);
> }
>
> if (err)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-04-17 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 2:27 [RFC]jbd2: use GFP_NOFS for blkdev_issue_flush Shaohua Li
2012-04-15 22:44 ` Dave Chinner
2012-04-17 9:58 ` Jan Kara [this message]
2012-04-24 1:53 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417095830.GE7198@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shli@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).