From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alex Elder <elder@dreamhost.com>
Cc: Sage Weil <sage@newdream.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: osd_req_encode_op() breakage?
Date: Wed, 18 Apr 2012 16:32:26 +0100 [thread overview]
Message-ID: <20120418153225.GA6589@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4F8ED911.90309@dreamhost.com>
On Wed, Apr 18, 2012 at 10:09:05AM -0500, Alex Elder wrote:
> Yes, you are absolutely correct.
>
> We have obviously not done endianness checks in this code for
> some time.
>
> I will commit a fix and credit you for it. I'll also make sure
> we are doing proper testing for this sort of thing on a regular
> basis.
FWIW, that got caught by sparse, but I would really recommend _testing_
on big-endian - getting an emulated headless e.g. mips box is fairly
easy with qemu; I'd done that with debian big-endian mips userland on
emulated malta and it didn't take much work to set up.
Speaking of sparse, I think we simply ought to add -D__CHECK_ENDIAN__
to CHECKFLAGS in top-level Makefile. It's not _that_ much noise
these days... Not sure which tree should that go through, though...
next prev parent reply other threads:[~2012-04-18 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 15:09 osd_req_encode_op() breakage? Alex Elder
2012-04-18 15:18 ` [PATCH] ceph: osd_client: fix endianness bug in osd_req_encode_op() Alex Elder
2012-04-18 15:32 ` Al Viro [this message]
2012-04-18 15:56 ` osd_req_encode_op() breakage? Yehuda Sadeh Weinraub
-- strict thread matches above, loose matches on Subject: below --
2012-04-14 2:34 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418153225.GA6589@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=elder@dreamhost.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).