linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Mark Salter <msalter@redhat.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] C6X: add support to build with BINFMT_ELF_FDPIC
Date: Sun, 22 Apr 2012 23:35:35 +0200	[thread overview]
Message-ID: <20120422213534.GA6570@merkur.ravnborg.org> (raw)
In-Reply-To: <1335129679.12741.4.camel@deneb.redhat.com>

> > 
> > > --- a/fs/Kconfig.binfmt
> > > +++ b/fs/Kconfig.binfmt
> > >
> > >  config BINFMT_ELF_FDPIC
> > >        bool "Kernel support for FDPIC ELF binaries"
> > >        default y
> > > -       depends on (FRV || BLACKFIN || (SUPERH32 && !MMU))
> > > +       depends on (FRV || BLACKFIN || (SUPERH32 && !MMU) || TMS320C6X)
> > 
> > shouldn't the main arch symbol be "C6X" to match arch/c6x/ ?
> 
> It probably should have been. Most architectures use that convention but
> there are notable exceptions like powerpc and sh.
Please do not repeat past mistakes.
It should be trivial to fix.

Allow TMS320C6X for a sinel relase along with C6X - and drop it
when all users outside your arch has switched over.

	Sam

  reply	other threads:[~2012-04-22 21:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 21:47 [PATCH] C6X: add support to build with BINFMT_ELF_FDPIC Mark Salter
2012-04-21  5:01 ` Mike Frysinger
2012-04-22 21:21   ` Mark Salter
2012-04-22 21:35     ` Sam Ravnborg [this message]
2012-04-23  0:55       ` Mark Salter
2012-04-23  3:04         ` Mike Frysinger
2012-04-22 22:09     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120422213534.GA6570@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=a-jacquiot@ti.com \
    --cc=arnd@arndb.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msalter@redhat.com \
    --cc=vapier.adi@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).