From: djwong <djwong@us.ibm.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@whamcloud.com>,
Zheng Liu <gnehzuil.liu@gmail.com>,
Andreas Dilger <adilger@dilger.ca>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] jbd2: reduce the number of writes when commiting a transacation
Date: Wed, 25 Apr 2012 13:34:34 -0700 [thread overview]
Message-ID: <20120425203434.GB6938@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20120424194108.GI18865@thunk.org>
On Tue, Apr 24, 2012 at 03:41:08PM -0400, Ted Ts'o wrote:
> On Mon, Apr 23, 2012 at 10:19:48PM +0000, djwong wrote:
> >
> > My huge checksum patchset _does_ include checksums for data blocks; see the
> > t_checksum field in struct journal_block_tag_s. iirc the corresponding journal
> > replay modifications will skip over corrupt data blocks and keep going.
>
> I need to check for this in the patches (and you may be doing this
> already), but in the kernel failed checksums should result in an
> ext4_error() call which will set the file system as corrupt and
> needing to be checked. And in e2fsck it should force a full check of
> the file system.
I'm fairly sure the kernel patch doesn't do that, I think it just skips the
block and moves on.
As for e2fsck... what does one do inside e2fsck to force a full check? Is that
just the equivalent of passing -f?
--D
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-04-25 20:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 11:06 [RFC] jbd2: reduce the number of writes when commiting a transacation Zheng Liu
2012-04-20 11:21 ` Andreas Dilger
2012-04-23 2:25 ` Zheng Liu
2012-04-23 6:24 ` Andreas Dilger
2012-04-23 7:23 ` Zheng Liu
2012-04-23 22:19 ` djwong
2012-04-24 19:41 ` Ted Ts'o
2012-04-25 20:34 ` djwong [this message]
2012-04-24 21:57 ` Jan Kara
2012-04-25 1:27 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425203434.GB6938@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger@dilger.ca \
--cc=adilger@whamcloud.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).