From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 7/7] writeback: Avoid iput() from flusher thread
Date: Mon, 30 Apr 2012 11:30:27 -0400
Message-ID: <20120430153027.GA24324@infradead.org>
References: <1332284191-21076-1-git-send-email-jack@suse.cz>
 <1332284191-21076-8-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:57247
	"EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751978Ab2D3Paa (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 30 Apr 2012 11:30:30 -0400
Content-Disposition: inline
In-Reply-To: <1332284191-21076-8-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> - * Wait for writeback on an inode to complete.
> + * Wait for writeback on an inode to complete. Called with i_lock held.
> + * Caller must make sure inode cannot go away when we drop i_lock.
>   */
> -static void inode_wait_for_writeback(struct inode *inode)
> +void inode_wait_for_writeback(struct inode *inode)
>  {
>  	DEFINE_WAIT_BIT(wq, &inode->i_state, __I_SYNC);
>  	wait_queue_head_t *wqh;
> @@ -340,6 +341,26 @@ static void inode_wait_for_writeback(struct inode *inode)
>  	}
>  }

This needs way better documentation, preferably using kernel doc.

I also suspect we should rename inode_wait_for_writeback to
__inode_wait_for_writeback and make inode_wait_for_writeback the public
wrapper that takes i_lock.

> diff --git a/fs/inode.c b/fs/inode.c
> index d3ebdbe..3869714 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -510,7 +510,6 @@ void end_writeback(struct inode *inode)
>  	BUG_ON(!list_empty(&inode->i_data.private_list));
>  	BUG_ON(!(inode->i_state & I_FREEING));
>  	BUG_ON(inode->i_state & I_CLEAR);
> -	inode_sync_wait(inode);
>  	/* don't need i_lock here, no concurrent mods to i_state */
>  	inode->i_state = I_FREEING | I_CLEAR;
>  }

end_writeback is really misnamed now and needs a better name.