From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] vfs: Speed up deactivate_super for non-modular filesystems Date: Mon, 7 May 2012 23:17:06 +0100 Message-ID: <20120507221706.GI22082@ZenIV.linux.org.uk> References: <1336124716.25479.36.camel@marge.simpson.net> <1336142995.25479.49.camel@marge.simpson.net> <1336150643.7502.4.camel@marge.simpson.net> <1336197362.7346.9.camel@marge.simpson.net> <1336198093.7346.11.camel@marge.simpson.net> <1336201977.7346.22.camel@marge.simpson.net> <87r4uv64oj.fsf_-_@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Oleg Nesterov , LKML , Pavel Emelyanov , Cyrill Gorcunov , Louis Rilling , "Paul E. McKenney" , Mike Galbraith , Christoph Hellwig , linux-fsdevel@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:36461 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753955Ab2EGWRR (ORCPT ); Mon, 7 May 2012 18:17:17 -0400 Content-Disposition: inline In-Reply-To: <87r4uv64oj.fsf_-_@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 07, 2012 at 02:51:08PM -0700, Eric W. Biederman wrote: > /proc and similar non-modular filesystems do not need a rcu_barrier > in deactivate_locked_super. Being non-modular there is no danger > of the rcu callback running after the module is unloaded. There's more than just a module unload there, though - actual freeing struct super_block also happens past that rcu_barrier()...