From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
swhiteho@redhat.com
Subject: Re: [PATCH 0/6] Get rid of I_MUTEX_QUOTA use
Date: Wed, 9 May 2012 17:34:02 -0400 [thread overview]
Message-ID: <20120509213402.GA28719@fieldses.org> (raw)
In-Reply-To: <20120430135434.GB5239@quack.suse.cz>
On Mon, Apr 30, 2012 at 03:54:34PM +0200, Jan Kara wrote:
> On Fri 27-04-12 09:47:52, J. Bruce Fields wrote:
> > On Thu, Apr 26, 2012 at 03:26:08PM +0200, Jan Kara wrote:
> > > On Wed 25-04-12 17:25:32, J. Bruce Fields wrote:
> > > > On Wed, Apr 25, 2012 at 10:57:41PM +0200, Jan Kara wrote:
> > > > >
> > > > > Hello,
> > > > >
> > > > > this patch set changes generic quota code (and filesystems relying on it)
> > > > > so that they don't use special locking class I_MUTEX_QUOTA. The only remaining
> > > > > user of I_MUTEX_QUOTA is GFS2. If noone has objections, I can merge these
> > > > > patches through my tree or Bruce, you can take them as your work depends
> > > > > on these changes.
> > > >
> > > > My changes will likely need to go through Al, and depend on GFS2 being
> > > > fixed as well.
> > > >
> > > > So it's up to Al. Best might be to just merge it through your tree and
> > > > let us sort it out in the next merge window?
> > > OK, I've added patches to my tree for now. I also sent a patch for GFS2
> > > but after some investigation that's mostly a cleanup grade and Steven can
> > > merge it independently. Quota inode in GFS2 is hidden system file so there
> > > should be no locking problems with it wrt your patches.
> >
> > OK. In that case I suppose I'd like Al to take patches 1-4 of the 5 I
> > posted most recently (followups to
> > http://mid.gmane.org/20120425152041.GA751@fieldses.org), probably after
> > your fixes go in. I'll resend if necessary after they go in.
> Yeah. But also please rename I_MUTEX_QUOTA to something better describing
> what's going on...
Yes. My uncreative replacement is I_MUTEX_NONDIR2 ("a second
non-directory object"), but I'd welcome any more elegant suggestion.
--b.
prev parent reply other threads:[~2012-05-09 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 20:57 [PATCH 0/6] Get rid of I_MUTEX_QUOTA use Jan Kara
2012-04-25 20:57 ` [PATCH 1/6] ext3: Remove i_mutex use from ext3_quota_write() Jan Kara
2012-04-25 20:57 ` [PATCH 2/6] ext4: Remove i_mutex use from ext4_quota_write() Jan Kara
2012-04-25 20:57 ` [PATCH 3/6] reiserfs: Remove i_mutex use from reiserfs_quota_write() Jan Kara
2012-04-25 20:57 ` [PATCH 4/6] ext2: Remove i_mutex use from ext2_quota_write() Jan Kara
2012-04-25 20:57 ` [PATCH 5/6] quota: Use precomputed value of sb_dqopt in dquot_quota_sync Jan Kara
2012-04-25 20:57 ` [PATCH 6/6] quota: Get rid of nested I_MUTEX_QUOTA locking subclass Jan Kara
2012-04-25 21:25 ` [PATCH 0/6] Get rid of I_MUTEX_QUOTA use J. Bruce Fields
2012-04-26 13:26 ` Jan Kara
2012-04-27 13:47 ` J. Bruce Fields
2012-04-30 13:54 ` Jan Kara
2012-05-09 21:34 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509213402.GA28719@fieldses.org \
--to=bfields@fieldses.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).