From: Evgeniy Dushistov <dushistov@mail.ru>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] update i_blocks on UFS
Date: Mon, 14 May 2012 15:57:02 +0400 [thread overview]
Message-ID: <20120514115702.GA11251@maclin> (raw)
In-Reply-To: <4FB032BB.6060209@gmail.com>
On Mon, May 14, 2012 at 12:16:27AM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 13.05.2012 23:59, Evgeniy Dushistov wrote:
>
> > On Sun, May 13, 2012 at 03:52:46PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> >> UFS code dosn't update i_blocks which leads to the problems ranging from wrong
> >> stat/du to long symlinks (as opposed to inline ones) being damaged. This is
> >> a fix.
> >>
> >
> > Yes, when quota support was removed, code that update statistic
> > about usage of blocks also was removed. But why so big change to fix this?
> > I found this problem some time ago and fixed it with code bellow,
> > but may be I missed something?
> >
>
> Hm, I don't know why this code wasn't in my copy. Was it already
> propagated to Linus' tree? When will it be? Which tree I should merge
> from to get your latest fixes?
I created this patch some time ago, but forgot to merge it to main tree.
You email remind me about this problem.
> My code avoided counting metadata blocks (the ones holding the pointers
> to actual blocks in indirect, double-indirect and triple-indirect
> chains). I thought that i_blocks doesn't take into account the
> metablocks but quick experiment with NetBSD image proved me wrong. So I
> retract this patch altogether.
> My UFS file size limit patch remains though.
>
ok, so I will test your patch and my and then take care about merging
them into mainline.
--
/Evgeniy
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-05-14 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 13:52 [PATCH] update i_blocks on UFS Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-13 21:59 ` Evgeniy Dushistov
2012-05-13 22:16 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-14 11:57 ` Evgeniy Dushistov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514115702.GA11251@maclin \
--to=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).