From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Dushistov Subject: Re: [PATCH] update i_blocks on UFS Date: Mon, 14 May 2012 15:57:02 +0400 Message-ID: <20120514115702.GA11251@maclin> References: <4FAFBCAE.1050401@gmail.com> <20120513215925.GA1998@maclin> <4FB032BB.6060209@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Vladimir =?utf-8?Q?'=CF=86-coder=2Fphcoder'?= Serbinenko Return-path: Received: from smtp24.mail.ru ([94.100.176.177]:53301 "EHLO smtp24.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755681Ab2ENL46 (ORCPT ); Mon, 14 May 2012 07:56:58 -0400 Content-Disposition: inline In-Reply-To: <4FB032BB.6060209@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 14, 2012 at 12:16:27AM +0200, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: > On 13.05.2012 23:59, Evgeniy Dushistov wrote: >=20 > > On Sun, May 13, 2012 at 03:52:46PM +0200, Vladimir '=CF=86-coder/ph= coder' Serbinenko wrote: > >> UFS code dosn't update i_blocks which leads to the problems rangin= g from wrong > >> stat/du to long symlinks (as opposed to inline ones) being damaged= =2E This is > >> a fix. > >> > >=20 > > Yes, when quota support was removed, code that update statistic > > about usage of blocks also was removed. But why so big change to fi= x this? > > I found this problem some time ago and fixed it with code bellow, > > but may be I missed something? > >=20 >=20 > Hm, I don't know why this code wasn't in my copy. Was it already > propagated to Linus' tree? When will it be? Which tree I should merge > from to get your latest fixes? I created this patch some time ago, but forgot to merge it to main tree= =2E You email remind me about this problem. > My code avoided counting metadata blocks (the ones holding the pointe= rs > to actual blocks in indirect, double-indirect and triple-indirect > chains). I thought that i_blocks doesn't take into account the > metablocks but quick experiment with NetBSD image proved me wrong. So= I > retract this patch altogether. > My UFS file size limit patch remains though. >=20 ok, so I will test your patch and my and then take care about merging them into mainline. --=20 /Evgeniy -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html