From: Jan Kara <jack@suse.cz>
To: Hugh Dickins <hughd@google.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org
Subject: Re: inode_dio_wait and hole-punch?
Date: Tue, 15 May 2012 00:42:09 +0200 [thread overview]
Message-ID: <20120514224209.GX5353@quack.suse.cz> (raw)
In-Reply-To: <alpine.LSU.2.00.1205131414270.1547@eggly.anvils>
On Sun 13-05-12 14:26:40, Hugh Dickins wrote:
> In looking through hole-punching implementations, I got the impression
> that perhaps ext4 and ocfs2 might need to inode_dio_wait() before they
> truncate pagecache. And that might require ext4 to hold i_mutex there?
Not necessarily before truncating page cache AFAICS but certainly before
we go and remove blocks from the file. In case of ext4 doing that before
ext4_flush_completed_IO() call would look most appropriate I'd think. Good
spotting! Will you send a patch?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-05-14 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 21:26 inode_dio_wait and hole-punch? Hugh Dickins
2012-05-14 22:42 ` Jan Kara [this message]
2012-05-15 1:13 ` Hugh Dickins
2012-05-15 10:18 ` Jan Kara
2012-05-15 6:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514224209.GX5353@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).