From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: Eliminating UDF iocharset!=utf8 code (Re: [PATCH 6/8] Support non-BMP characters in UDF) Date: Thu, 17 May 2012 16:40:32 +0200 Message-ID: <20120517144032.GA10676@quack.suse.cz> References: <4FB2E25E.900@gmail.com> <20120516143448.GD27661@quack.suse.cz> <4FB3C44F.6080409@gmail.com> <20120516200459.GD1687@quack.suse.cz> <4FB44856.40102@gmail.com> <4FB44AF1.4060103@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Vladimir =?utf-8?Q?'=CF=86-coder=2Fphcoder'?= Serbinenko Return-path: Received: from cantor2.suse.de ([195.135.220.15]:32987 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760921Ab2EQOkr (ORCPT ); Thu, 17 May 2012 10:40:47 -0400 Content-Disposition: inline In-Reply-To: <4FB44AF1.4060103@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 17-05-12 02:48:49, Vladimir '=CF=86-coder/phcoder' Serbinenko wr= ote: >=20 > > I've noticed another duplication in the UDF code: there > > is NLS support and separate UTF-8 support. UTF-8 is support by 2 wa= ys > > actually: with -o utf8 and -o iocharset=3Dutf8 which imply differen= t > > codepaths. Specific UTF-8 support is probably slightly faster by > > avoiding calls and basically doing everything with shifts (or can b= e > > made so with a small patch). Should I perhaps kill one of them? Is > > iocharset!=3Dutf8 still of any importance? I haven't seen it in age= s. > > Perhaps we could keep just the performant UTF-8 support and map > > iocharset=3Dutf8 to it and drop iocharset!=3Dutf8? iocharset!=3Dutf= 8 probably > > has no users anyway so keeping it we're likely to keep bugs and cod= e > > duplication with no benefit. > >=20 >=20 > Linux seems to support UTF-8-only pretty strongly: http://yarchive.ne= t/comp/linux/utf8.html > (message from Sun, 15 Feb 2004 02:42:45 GMT). > And I completely agree. > If it's ok to kill iocharset!=3Dutf8 I'll propose a series of 3 patch= es (killing iocharset!=3Dutf8, > extending utf16toutf8/utf8toutf16 for unaligned input, changing UDF c= ode to use common functions) Well, yes, utf8 is currently the only sane setting but that doesn't m= ean someone isn't using (e.g. iso8859-2) for strange reasons... We should regress in user visible functionality only for really good reasons and = here I don't see a strong reason. So I'd like to keep current iocharset moun= t option and make utf8 option equivalent to iocharset=3Dutf8. Since I don= 't think the speed benefit of dedicated CS0<->UTF8 functions is really tha= t big and UDF isn't exactly a filesystem where it would matter anyway, I'= d just remove those dedicated functions and use the generic ones instead. Honza --=20 Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html