From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
ebiederm@xmission.com, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: /proc/pid/fd/ shows strange mode when executed via sudo.
Date: Fri, 18 May 2012 19:08:12 +0100 [thread overview]
Message-ID: <20120518180812.GR22082@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFwHgU6zBX6ZGFU+6vjvbCwhkHB7M2Sqp1g4y3+ea+Lp3w@mail.gmail.com>
> I would suggest just moving the i_mode initialization from
> proc_fd_instantiate() into the revalidate function that we already
> have, and that already fixes up i_uid/i_gid etc. Attached is a TOTALLY
> UNTESTED patch that does this, and actually seems to simplify things
> in the process.
I think this is bogus. We don't give a fuck about *any* of those fields
for symlinks; the only problem here is that default ->getattr() uses
them to fill ->st_mode et.al. The same goes for ->i_uid/->i_gid.
So how about simply adding ->getattr() for those guys? And to hell
with assignments in that ->d_revalidate() instance...
next prev parent reply other threads:[~2012-05-18 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 13:40 /proc/pid/fd/ shows strange mode when executed via sudo Tetsuo Handa
2012-05-03 15:42 ` Serge Hallyn
2012-05-03 16:25 ` Tetsuo Handa
2012-05-18 2:39 ` Tetsuo Handa
2012-05-18 9:27 ` Tetsuo Handa
2012-05-18 16:08 ` Linus Torvalds
2012-05-18 16:25 ` Linus Torvalds
2012-05-18 19:55 ` Eric W. Biederman
2012-05-18 18:08 ` Al Viro [this message]
2012-05-18 18:18 ` Linus Torvalds
2012-05-18 18:23 ` Linus Torvalds
2012-05-18 18:45 ` Al Viro
2012-05-18 18:55 ` Linus Torvalds
2012-05-18 19:10 ` Al Viro
2012-05-18 20:49 ` Linus Torvalds
2012-05-18 21:23 ` Al Viro
2012-05-18 21:26 ` Linus Torvalds
2012-05-18 21:32 ` Linus Torvalds
2012-05-18 22:29 ` Al Viro
2012-05-19 7:08 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518180812.GR22082@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).