From: "Serge E. Hallyn" <serge@hallyn.com>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Daniel Lezcano <dlezcano@fr.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Miklos Szeredi <mszeredi@suse.cz>
Subject: Re: [PATCH] vfs: Add setns support for the mount namespace
Date: Fri, 18 May 2012 19:44:17 +0000 [thread overview]
Message-ID: <20120518194417.GA14195@mail.hallyn.com> (raw)
In-Reply-To: <4FAE4C70.5000804@parallels.com>
Quoting Pavel Emelyanov (xemul@parallels.com):
> On 05/12/2012 12:54 AM, Eric W. Biederman wrote:
> >
> > setns support for the mount namespace is a little tricky as an arbitrary
> > decision must be made about what to set fs->root and fs->pwd to, as
> > there is no expectation of a relationship between the two mount
> > namespaces. Therefore I arbitrarily find the root mount point, and
> > follow every mount on top of it to find the top of the mount stack.
> > Then I set fs->root and fs->pwd to that location. The topmost root of
> > the mount stack seems like a reasonable place to be.
> >
> > Bind mount support for the mount namespace inodes has the possibility of
> > creating circular dependencies between mount namespaces. Circular
> > dependencies can result in loops that prevent mount namespaces from
> > every being freed. I avoid creating those circular dependencies by
> > adding a sequence number to the mount namespace and require all bind
> > mounts be of a younger mount namespace into an older mount namespace.
> >
> > Add a helper function proc_ns_inode so it is possible to detect when we
> > are attempting to bind mound a namespace inode.
> >
> > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
>
> Acked-by: Pavel Emelyanov <xemul@parallels.com>
These patches haven't made it into linux-next or Linus' tree. (More
worrisome, is that the several online linux-kernel mail archives I've
checked seem to have most of this thread, but not Eric's original
patch.) What path were they expected to go in by?
thanks,
-serge
next prev parent reply other threads:[~2012-05-18 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FAD0524.3000307@parallels.com>
[not found] ` <4FAD0555.4090906@parallels.com>
[not found] ` <87mx5e5tho.fsf_-_@xmission.com>
2012-05-12 11:41 ` [PATCH] vfs: Add setns support for the mount namespace Pavel Emelyanov
2012-05-18 19:44 ` Serge E. Hallyn [this message]
2012-05-18 22:47 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518194417.GA14195@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=viro@ZenIV.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).