From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Ts'o Subject: Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code. Date: Mon, 21 May 2012 19:31:33 -0400 Message-ID: <20120521233133.GG12339@thunk.org> References: <1337500880.16053.YahooMailNeo@web192405.mail.sg3.yahoo.com> <1337570918.78986.YahooMailNeo@web192406.mail.sg3.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: manish honap , "adilger.kernel@dilger.ca" , "linux-fsdevel@vger.kernel.org" , linux-ext4@vger.kernel.org To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote: > > So I'm pretty sure this patch is what we want, and rw_verify_area() > really is required to protect low-level filesystems from these kinds > of issues. Not just ext4. > > At the same time, I would *really* want somebody who actually uses > anything AIO to test it out too. Because I want to not only commit it, > but also mark it for stable - and it would be nice to have some more > testing than me saying "ok, it passes the one test-case sent to me" > and "hey, the code looks sane". Hi Linus, We do use AIO at Google, and I primarily use fio (usually as part of xfstests) to test AIO functionality. If you like I can carry the patch in the ext4 tree and test it as part of the ext4 commits for the merge window. I probably won't be able to get to it until a bit later in the week, though. Things have been really crazy for me this past two months... - Ted