linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	viro@ZenIV.linux.org.uk, sami.liedes@iki.fi
Subject: Re: [PATCH] vfs: avoid hang caused by attempting to rmdir an invalid file system
Date: Tue, 29 May 2012 17:21:44 +0900	[thread overview]
Message-ID: <20120529082144.GA18792@kroah.com> (raw)
In-Reply-To: <1338226422-8845-1-git-send-email-tytso@mit.edu>

On Mon, May 28, 2012 at 01:33:42PM -0400, Theodore Ts'o wrote:
> If we rmdir a directory which is a hard link to '.', we will deadlock
> trying to grab the directory's i_mutex.  Check for this condition and
> return EINVAL, which is what we return if the user attempts to rmdir
> "/foo/bar/."
> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
>  fs/namei.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Any reason why you didn't also tag this for the stable kernel releases?

thanks,

greg k-h

  parent reply	other threads:[~2012-05-29  8:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28 17:33 [PATCH] vfs: avoid hang caused by attempting to rmdir an invalid file system Theodore Ts'o
2012-05-28 20:29 ` Andreas Dilger
2012-05-28 21:05   ` Ted Ts'o
2012-05-29 19:50     ` Jan Kara
2012-05-29 20:08       ` Jan Kara
2012-05-30 17:37         ` J. Bruce Fields
2012-05-30 20:12           ` Jan Kara
2012-06-18 21:19             ` J. Bruce Fields
2012-06-20  9:57               ` Jan Kara
2012-05-29  8:21 ` Greg KH [this message]
2012-05-29 12:18   ` Ted Ts'o
2012-05-29 11:25 ` Bernd Schubert
     [not found] <20120528173133.GA31109@thunk.org>
2012-05-28 17:34 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120529082144.GA18792@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sami.liedes@iki.fi \
    --cc=tytso@mit.edu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).