From mboxrd@z Thu Jan 1 00:00:00 1970 From: "majianpeng" Subject: Re: Re: [PATCH] export kernel call set_task_comm() Date: Fri, 1 Jun 2012 09:15:42 +0800 Message-ID: <201206010915397186701@gmail.com> References: <201205311516140150468@gmail.com>, <20120531160054.GG11775@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 7bit Cc: "linux-fsdevel" To: "Al Viro" Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:63742 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932979Ab2FABOv (ORCPT ); Thu, 31 May 2012 21:14:51 -0400 Received: by dady13 with SMTP id y13so2046420dad.19 for ; Thu, 31 May 2012 18:14:50 -0700 (PDT) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 31 May 2012 17:00:54 +0100 , viro wrote: >On Thu, May 31, 2012 at 03:16:18PM +0800, majianpeng wrote: >> In Commit 7d74f492e4dd0034a61458eb80f70b1d2862ed07,author said: >> "This allows drivers who call this function to be compiled modularly. >> Otherwise, a driver who is interested in this type of functionality >> has to implement their own get_task_comm() call, causing code >> duplication in the Linux source tree." >> >> But author did not say about set_task_comm().At present,I used it but >> compiled error.To the same purpose, it should export. >Are you doing that to preexisting process? Or just to a kernel thread >you are creating? In the latter case, you really ought to use >kthread_create() instead of bare-metal kernel_thread()... Yes, I am doing that to preexisting process and in module.So I think it should export. ------------------ majianpeng 2012-06-01