From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Add Apple NLS Date: Fri, 1 Jun 2012 14:57:41 -0700 Message-ID: <20120601145741.c6289ea9.akpm@linux-foundation.org> References: <4FAFBE24.7000307@gmail.com> <20120517154707.c3dc2795.akpm@linux-foundation.org> <4FB5D1C8.7020305@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Vladimir =?UTF-8?Q?'=CF=86-coder/phcoder'?= Serbinenko , Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Yinghai Lu Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 1 Jun 2012 12:36:11 -0700 Yinghai Lu wrote: > On Thu, May 17, 2012 at 9:36 PM, Vladimir '__-coder/phcoder' Serbinenko > wrote: > >> Also, I note that the unicode files have > >> > >> __ __ __ MODULE_LICENSE("Dual BSD/GPL"); > >> > >> Where did this come from? __Is this a thing you decided upon or is it > >> unicode.org's license requirement? > >> > > looks like Makefile change is not right... it has hard code =m for new modules. > > those line should be removed. Yup. This? From: Andrew Morton Subject: fs/nls/Makefile: remove bogus CONFIG_ assignments I assume these were debug things whcih snuck through. Reported-by: Yinghai Lu Cc: Vladimir Serbinenko Signed-off-by: Andrew Morton --- fs/nls/Makefile | 12 ------------ 1 file changed, 12 deletions(-) diff -puN fs/nls/Makefile~fs-nls-makefile-remove-bogus-config_-assignemnts fs/nls/Makefile --- a/fs/nls/Makefile~fs-nls-makefile-remove-bogus-config_-assignemnts +++ a/fs/nls/Makefile @@ -2,18 +2,6 @@ # Makefile for native language support # -CONFIG_NLS_MACCELTIC=m -CONFIG_NLS_MACCENTEURO=m -CONFIG_NLS_MACCROATIAN=m -CONFIG_NLS_MACCYRILLIC=m -CONFIG_NLS_MACGAELIC=m -CONFIG_NLS_MACGREEK=m -CONFIG_NLS_MACICELAND=m -CONFIG_NLS_MACINUIT=m -CONFIG_NLS_MACROMANIAN=m -CONFIG_NLS_MACROMAN=m -CONFIG_NLS_MACTURKISH=m - obj-$(CONFIG_NLS) += nls_base.o obj-$(CONFIG_NLS_CODEPAGE_437) += nls_cp437.o _