From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 14/27] fs: Add freezing handling to mnt_want_write() / mnt_drop_write() Date: Wed, 6 Jun 2012 18:04:57 +1000 Message-ID: <20120606080457.GD3019@devil.redhat.com> References: <1338589841-9568-1-git-send-email-jack@suse.cz> <1338589841-9568-15-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Al Viro To: Jan Kara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888Ab2FFIFa (ORCPT ); Wed, 6 Jun 2012 04:05:30 -0400 Content-Disposition: inline In-Reply-To: <1338589841-9568-15-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jun 02, 2012 at 12:30:28AM +0200, Jan Kara wrote: > Most of places where we want freeze protection coincides with the places where > we also have remount-ro protection. So make mnt_want_write() and > mnt_drop_write() (and their _file alternative) prevent freezing as well. > For the few cases that are really interested only in remount-ro protection > provide new function variants. > > BugLink: https://bugs.launchpad.net/bugs/897421 > Tested-by: Kamal Mostafa > Tested-by: Peter M. Petrakis > Tested-by: Dann Frazier > Tested-by: Massimo Morana > Signed-off-by: Jan Kara > --- > fs/file_table.c | 2 +- > fs/inode.c | 4 +- > fs/namei.c | 16 +++++++- The changes to the fs/inode.c and fs/namei.c file don't apply. the fs/inode.c fixup is trivial, but do_last() has been significantly modified since this patch was created and it's not exactly obvious to me how to fix this. Can you rebase the series on, say, 3.5-rc1, Jan? Cheers, Dave. -- Dave Chinner dchinner@redhat.com