From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ted Ts'o Subject: Re: writeback: bad unlock balance detected in 3.5-rc1 Date: Fri, 8 Jun 2012 22:38:04 -0400 Message-ID: <20120609023804.GC14153@thunk.org> References: <20120608150736.GF21080@quack.suse.cz> <20120608202840.GB1704@thunk.org> <20120608233728.GA7691@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Fengguang Wu Return-path: Received: from li9-11.members.linode.com ([67.18.176.11]:48676 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600Ab2FICiN (ORCPT ); Fri, 8 Jun 2012 22:38:13 -0400 Content-Disposition: inline In-Reply-To: <20120608233728.GA7691@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jun 09, 2012 at 08:37:28AM +0900, Fengguang Wu wrote: > > Here is the updated changelog: > > writeback: Fix lock imbalance in writeback_sb_inodes() > > Fix bug introduced by 169ebd90. We have to have wb_list_lock locked when > restarting writeback loop after having waited for inode writeback. > > Bug description by Ted Tso: > > I can reproduce this fairly easily by using ext4 w/o a journal, running > under KVM with 1024megs memory, with fsstress (xfstests #13): Not that it matters that much, but I typo'ed the description; sorry about that. The KVM only had 1024k of memory.... - Ted