From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH] writeback: fix hung_task alarm when sync block
Date: Wed, 13 Jun 2012 09:18:17 +0800 [thread overview]
Message-ID: <20120613011817.GA24315@localhost> (raw)
In-Reply-To: <20120613011151.GA2181@kernel>
> >> @@ -1311,7 +1312,12 @@ void writeback_inodes_sb_nr(struct super_block *sb,
> >>
> >> WARN_ON(!rwsem_is_locked(&sb->s_umount));
> >> bdi_queue_work(sb->s_bdi, &work);
> >> - wait_for_completion(&done);
> >> + hangcheck = sysctl_hung_task_timeout_secs;
> >> + if (hangcheck)
> >
> >The hangcheck variable looks redundant.
>
> if sysctl_hung_task_timeout_secs is equal to ZERO, it means infinite
> timeout -- no checking done. So I think wait_for_completion_timeout
> makes no sense this time.
I mean, you can test sysctl_hung_task_timeout_secs directly?
It's a one shot test anyway.
> >> + while (!wait_for_completion_timeout(&done, HZ/2))
> >> + ;
> >> + else
> >> + wait_for_completion(&done);
> >> }
> >> EXPORT_SYMBOL(writeback_inodes_sb_nr);
> >>
> >> --
> >> 1.7.9.5
next prev parent reply other threads:[~2012-06-13 1:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 0:52 [PATCH] writeback: fix hung_task alarm when sync block Wanpeng Li
2012-06-13 0:59 ` Fengguang Wu
2012-06-13 1:12 ` Wanpeng Li
2012-06-13 1:18 ` Fengguang Wu [this message]
2012-06-13 1:30 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613011817.GA24315@localhost \
--to=fengguang.wu@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwp.linux@gmail.com \
--cc=shangw@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).