From: Dave Chinner <david@fromorbit.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Dave Chinner <dchinner@redhat.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: add FALLOC_FL_ZERO_RANGE to fallocate
Date: Thu, 14 Jun 2012 09:52:56 +1000 [thread overview]
Message-ID: <20120613235256.GX22848@dastard> (raw)
In-Reply-To: <4FD8320C.1060308@redhat.com>
On Wed, Jun 13, 2012 at 08:24:12AM +0200, Paolo Bonzini wrote:
> Il 13/06/2012 04:16, Dave Chinner ha scritto:
> >> > + BUG_ON((mode & FALLOC_FL_PUNCH_HOLE) && (mode & FALLOC_FL_ZERO_RANGE));
> > Never put BUG_ON() or BUG() in XFS code that can return an error.
> > Return EINVAL if we chose not to support it, and if it's really
> > something we consider bad, emit a warning to syslog (i.e.
> > xfs_warn()) and potentially add a ASSERT() case so that debug
> > kernels will trip over it. Nobody should be panicing a production
> > system just because a user supplied a set of incorrect syscall
> > paramters....
>
> I know, the BUG_ON() is because it is ruled out in VFS code. Of course
> if I remove that code, this will not be a BUG_ON() anymore.
If we put a BUG_ON() for every condition the VFS checked in every
filesystem, we'd have so many BUG_ON checks we wouldn't be able to
find the code. If it's banned at the VFS, there's no need to assert
that inthe filesystem code....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-06-13 23:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 15:36 [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate Paolo Bonzini
2012-06-12 15:36 ` [PATCH 1/2] vfs: add " Paolo Bonzini
2012-06-13 1:55 ` Dave Chinner
2012-06-12 15:36 ` [PATCH 2/2] xfs: " Paolo Bonzini
2012-06-13 2:16 ` Dave Chinner
2012-06-13 6:24 ` Paolo Bonzini
2012-06-13 23:52 ` Dave Chinner [this message]
2012-06-13 1:35 ` [PATCH 0/2] Add " Dave Chinner
2012-06-13 3:30 ` Dave Chinner
2012-06-13 6:13 ` Paolo Bonzini
2012-06-13 23:51 ` Dave Chinner
2013-11-05 10:34 ` Christoph Hellwig
2013-11-05 10:36 ` Paolo Bonzini
2013-11-05 16:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613235256.GX22848@dastard \
--to=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).