From: Dave Chinner <david@fromorbit.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jeff Moyer <jmoyer@redhat.com>, Wanpeng Li <liwp.linux@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH V2] writeback: fix hung_task alarm when sync block
Date: Sat, 16 Jun 2012 08:43:06 +1000 [thread overview]
Message-ID: <20120615224306.GG19223@dastard> (raw)
In-Reply-To: <20120613144840.GA3055@localhost>
On Wed, Jun 13, 2012 at 10:48:40PM +0800, Fengguang Wu wrote:
> > This really feels like we're papering over the problem.
>
> That's true. The majority users probably don't want to cache 100s
> worth of data in memory. It may be worthwhile to add a new per-bdi
> limit whose unit is number-of-seconds (of dirty data).
Doesn't work. You have a BBWC that takes in 500MB of random 4k
writes in a second, then starts to flush and needs to do a RMW cycle
for every 4k write it cached. On RAID5/6, the flush rate will be
about 100 IOPS, so it could take half an hour to flush those writes
that took a second to dump into the cache. IO for that entire half
hour will be extremely slow, and if you isue a sync during it, then
that's when you get a hung task timer.
Limiting the amount of writeback to a few seconds of IO simply won't
fix this - the ingest rate of BBWCs is simply too great to prevent
such events by a slow moving bandwidth throttle....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-06-15 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 4:42 [PATCH V2] writeback: fix hung_task alarm when sync block Wanpeng Li
2012-06-13 14:27 ` Jeff Moyer
2012-06-13 14:48 ` Fengguang Wu
2012-06-13 14:55 ` Fengguang Wu
2012-06-13 15:34 ` Jeff Moyer
2012-06-14 13:36 ` Fengguang Wu
2012-06-19 20:14 ` Jeff Moyer
2012-06-19 21:02 ` Dave Chinner
2012-06-19 21:09 ` Jeff Moyer
2012-06-19 21:56 ` Dave Chinner
2012-06-14 1:35 ` Wanpeng Li
2012-06-14 13:26 ` Fengguang Wu
2012-06-15 22:43 ` Dave Chinner [this message]
2012-06-14 10:52 ` Wanpeng Li
2012-06-15 22:38 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615224306.GG19223@dastard \
--to=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwp.linux@gmail.com \
--cc=shangw@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).