Re: [PATCH 2/3] ext4: Context support

[Arnd Bergmann <arnd.bergmann@linaro.org>]

On Wednesday 20 June 2012, Luca Porzio (lporzio) wrote:
> > > > * We can only start the large unit at the start of an erase block. If
> > > >   we unmount the drive and later continue writing, it has to continue
> > > >   without the large-unit flag at first until we hit an erase block
> > > >   boundary.
> > >
> > > My assumption was that when you umount the drive, the file system
> > > would close all of the contexts.
> > 
> > Yes, makes sense. This is probably required to ensure that the data
> > has made to the drive, at least for the large contexts, but it is
> > definitely required for housekeeping of contexts if we manage them
> > from the block layer.
> > 
> 
> One comment here, large unit contexts (according to spec) are not bounded
> to erase blocks. They can span one or more blocks, actually they are not
> related to block size at all (just virtual page size of the device which
> can be read from the EXT_CSD configuration registers for eMMC).

Well, when I say erase block, I really mean the "large unit", which is some
multiple of entire megabytes, because the only reasonable way to use this
is to define this to the size of the erase block or a very small multiple
of that. When detecting the "erase block size" of an eMMC, we should report
the smallest multiple of the ERASE_GPR_SIZE, HC_ERASE_GRP_SIZE and 
LARGE_UNIT_SIZE_M1.

	Arnd