From: Wanpeng Li <liwp.linux@gmail.com>
To: Cong Meng <mc@linux.vnet.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Wanpeng Li <liwp.linux@gmail.com>
Subject: Re: [PATCH] VFS: Go through the LRU list of inode from head
Date: Thu, 21 Jun 2012 17:47:55 +0800 [thread overview]
Message-ID: <20120621094755.GD2439@kernel> (raw)
In-Reply-To: <1340269227-20310-1-git-send-email-mc@linux.vnet.ibm.com>
On Thu, Jun 21, 2012 at 05:00:27PM +0800, Cong Meng wrote:
>Go through the LRU list of inode from head.
IIRC, prune_icache_sb is called(as a shrinker in shrink_slab) in page reclaim
path, it is used to free icache. Tail entry in LRU(Least Recently Used) list
is the least recently used inode object. When the inode cache has to shrink,
the kernel removes entries from the tail.
>
>(I'm not sure whether there is any trick here I doesn't get. If yes,
>any one could explain it)
>
>Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com>
>---
> fs/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/fs/inode.c b/fs/inode.c
>index 775cbab..aac8449 100644
>--- a/fs/inode.c
>+++ b/fs/inode.c
>@@ -704,7 +704,7 @@ void prune_icache_sb(struct super_block *sb, int nr_to_scan)
> if (list_empty(&sb->s_inode_lru))
> break;
>
>- inode = list_entry(sb->s_inode_lru.prev, struct inode, i_lru);
>+ inode = list_entry(sb->s_inode_lru.next, struct inode, i_lru);
>
> /*
> * we are inverting the sb->s_inode_lru_lock/inode->i_lock here,
>--
>1.7.5.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-06-21 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 9:00 [PATCH] VFS: Go through the LRU list of inode from head Cong Meng
2012-06-21 9:47 ` Wanpeng Li [this message]
2012-06-21 9:52 ` Jan Kara
2012-06-26 7:35 ` mc
2012-06-27 16:08 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621094755.GD2439@kernel \
--to=liwp.linux@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).