From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 00/21] vfs: atomic open v6 (part 2) Date: Fri, 22 Jun 2012 11:07:47 +0100 Message-ID: <20120622100747.GE14083@ZenIV.linux.org.uk> References: <1338901832-14049-1-git-send-email-miklos@szeredi.hu> <20120610034921.GB30000@ZenIV.linux.org.uk> <20120610111056.GD30000@ZenIV.linux.org.uk> <20120610175605.GE30000@ZenIV.linux.org.uk> <20120610222745.GG30000@ZenIV.linux.org.uk> <20120617203755.GA31478@infradead.org> <20120618115804.GA4048@infradead.org> <20120618131252.GA21931@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, dhowells@redhat.com, mszeredi@suse.cz To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20120618131252.GA21931@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jun 18, 2012 at 09:12:52AM -0400, Christoph Hellwig wrote: > And here is fix number two, to be folded into the same commit: Both folded. FWIW, I'm not sure I'm happy about the reorg of failure exits in follow_link() - gcc can't figure out that follow_link(..., &cookie) can't return 0 without having passed through the assignment to cookie. Hell knows; I still don't like the calling conventions in that one...