From: Al Viro <viro@ZenIV.linux.org.uk>
To: wfg@linux.intel.com
Cc: linux-fsdevel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: vfs/for-next: NULL pointer dereference in sysfs_dentry_delete()
Date: Sun, 24 Jun 2012 10:20:34 +0100 [thread overview]
Message-ID: <20120624092034.GP14083@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120624080740.GA8331@localhost>
On Sun, Jun 24, 2012 at 04:07:40PM +0800, wfg@linux.intel.com wrote:
> Hi Al,
>
> This commit
>
> commit 08eaca322cb2720f1730e46793dee9464ebd26f2
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date: Thu Jun 7 20:51:39 2012 -0400
>
> sysfs: switch to ->s_d_op and ->d_release()
>
> triggers the following bug:
Arrgh....
It needs
static int sysfs_dentry_delete(const struct dentry *dentry)
{
struct sysfs_dirent *sd = dentry->d_fsdata;
return !(sd && !(sd->s_flags & SYSFS_FLAG_REMOVED));
}
Will fold and push in a few
prev parent reply other threads:[~2012-06-24 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 8:07 vfs/for-next: NULL pointer dereference in sysfs_dentry_delete() wfg
2012-06-24 9:20 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120624092034.GP14083@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).