From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: vfs/for-next: NULL pointer dereference in sysfs_dentry_delete()
Date: Sun, 24 Jun 2012 10:20:34 +0100
Message-ID: <20120624092034.GP14083@ZenIV.linux.org.uk>
References: <20120624080740.GA8331@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
To: wfg@linux.intel.com
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:42832 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752842Ab2FXJUf (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 24 Jun 2012 05:20:35 -0400
Content-Disposition: inline
In-Reply-To: <20120624080740.GA8331@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, Jun 24, 2012 at 04:07:40PM +0800, wfg@linux.intel.com wrote:
> Hi Al,
> 
> This commit
> 
>         commit 08eaca322cb2720f1730e46793dee9464ebd26f2
>         Author: Al Viro <viro@zeniv.linux.org.uk>
>         Date:   Thu Jun 7 20:51:39 2012 -0400
> 
>             sysfs: switch to ->s_d_op and ->d_release()
>             
> triggers the following bug:

Arrgh....
It needs
static int sysfs_dentry_delete(const struct dentry *dentry)
{
        struct sysfs_dirent *sd = dentry->d_fsdata;
        return !(sd && !(sd->s_flags & SYSFS_FLAG_REMOVED));
}

Will fold and push in a few