From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Rob Landley <rob@landley.net>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alan Cox <alan@linux.intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Doug Ledford <dledford@redhat.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
James Morris <james.l.morris@oracle.com>,
Joe Korty <joe.korty@ccur.com>,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5] fs: make dumpable=2 require fully qualified path
Date: Mon, 25 Jun 2012 15:28:53 -0700 [thread overview]
Message-ID: <20120625152853.1ec6a824.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jL8XpkWhFkWtdQA7egR+pOmu5TVjK7NTzeVEr=sqcmePw@mail.gmail.com>
On Mon, 25 Jun 2012 15:20:19 -0700
Kees Cook <keescook@chromium.org> wrote:
> On Mon, Jun 25, 2012 at 3:14 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Mon, 25 Jun 2012 11:03:27 -0700
> > Kees Cook <keescook@chromium.org> wrote:
> >
> >> Instead of introducing a suid_dumpable=3 mode and breaking all users
> >> of mode 2, this only disables the unsafe portion of mode 2 (writing to
> >> disk via relative path).
> >
> > It would be nicer to generate the warning at configuration time rather than
> > at core-dumping time. __I have a feeling that's Hard To Do, but why?
>
> I actually feel that this is much more discoverable because anyone
> trying to figure out why a crash isn't dumping core isn't going to be
> looking back in time through their dmesg to find the warning from
> setting the sysctl. Additionally, I think it's the same kind of thing
> that the other existing "Skipping core dump" printk messages are
> reporting.
People who don't discover we changed their kernel until after they lost
an important core dump will be sad. Do both?
prev parent reply other threads:[~2012-06-25 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 18:03 [PATCH v5] fs: make dumpable=2 require fully qualified path Kees Cook
2012-06-25 22:14 ` Andrew Morton
2012-06-25 22:20 ` Kees Cook
2012-06-25 22:28 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625152853.1ec6a824.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=dledford@redhat.com \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=joe.korty@ccur.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=serge.hallyn@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).