From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, tj@kernel.org, jmoyer@redhat.com,
vgoyal@redhat.com, dm-devel@redhat.com
Subject: Re: [RFC PATCH] block: all callers should check blkdev_issue_flush's return
Date: Tue, 26 Jun 2012 11:57:50 -0400 [thread overview]
Message-ID: <20120626155750.GA3494@redhat.com> (raw)
In-Reply-To: <20120626155115.GA17242@infradead.org>
On Tue, Jun 26 2012 at 11:51am -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Jun 26, 2012 at 11:27:25AM -0400, Mike Snitzer wrote:
> > It is concerning that a FLUSH may fail but the blkdev_issue_flush
> > callers assume it will always succeed.
> >
> > Each blkdev_issue_flush caller should come to terms with the reality
> > that a FLUSH may fail -- the file_operations' .fsync methods in
> > particular. nilfs2 is the only filesystem that checks
> > blkdev_issue_flush's return.
>
> Good spot, but it would be way better if you actually provided patches
> to fix this instead of just adding more compiler warnings.
Alasdair pointed this issue out in response to me asserting that
blkdev_issue_flush does return non-void. But anyway, others knowing
about this issue is half the battle. ;)
Most .fsync methods are straight-forward to convert but I'd prefer each
filesystem maintainer actively audit all blkdev_issue_flush calls.
next prev parent reply other threads:[~2012-06-26 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 15:27 [RFC PATCH] block: all callers should check blkdev_issue_flush's return Mike Snitzer
2012-06-26 15:33 ` Jeff Moyer
2012-06-26 15:51 ` Christoph Hellwig
2012-06-26 15:57 ` Mike Snitzer [this message]
2012-07-01 7:28 ` Joel Becker
2012-07-02 14:35 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626155750.GA3494@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).