From: Marc MERLIN <marc@merlins.org>
To: Alexander Block <ablock84@googlemail.com>
Cc: linux-btrfs@vger.kernel.org, dave@jikos.cz, hch@infradead.org,
linux-fsdevel@vger.kernel.org, chris.mason@fusionio.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow cross subvolume reflinks (2nd attempt)
Date: Wed, 27 Jun 2012 10:21:30 -0700 [thread overview]
Message-ID: <20120627172130.GD7472@merlins.org> (raw)
In-Reply-To: <1340188512-5761-1-git-send-email-ablock84@googlemail.com>
On Wed, Jun 20, 2012 at 12:35:11PM +0200, Alexander Block wrote:
> Hello,
>
> This is the second attempt to bring in cross subvolume reflinks into btrfs.
> The first attempt was NAKed due to missing vfs mount checks and a clear
> description of what btrfs subvolumes are and probably also why cross
> subvolume reflinks are ok in the case of btrfs. This version of the patch
> comes from David and is in SUSE kernels since a long time, so it is tested
> and working. The patch also does proper vfs mount checks, so cross mount
> point reflinks are not possible with this patch. It only allows cross
> reflinks between two subvolumes which are in the same mount point.
Thank you for bringing this back. This would have saved me a lot of
trouble
I'm not familiar with the code, but here's a big thumbs up from me.
Anyone doing reviews, please consider this :)
Thanks,
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
prev parent reply other threads:[~2012-06-27 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 10:35 [PATCH] Allow cross subvolume reflinks (2nd attempt) Alexander Block
2012-06-20 10:35 ` [PATCH] btrfs: allow cross-subvolume file clone Alexander Block
2012-06-20 17:18 ` [PATCH] Allow cross subvolume reflinks (2nd attempt) Goffredo Baroncelli
2012-06-20 17:27 ` Alexander Block
2012-06-20 18:07 ` Calvin Walton
2012-06-20 18:11 ` Goffredo Baroncelli
2012-06-20 20:05 ` Alexander Block
2012-06-20 20:15 ` Goffredo Baroncelli
2012-06-27 17:21 ` Marc MERLIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627172130.GD7472@merlins.org \
--to=marc@merlins.org \
--cc=ablock84@googlemail.com \
--cc=chris.mason@fusionio.com \
--cc=dave@jikos.cz \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).