From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc MERLIN Subject: Re: [PATCH] Allow cross subvolume reflinks (2nd attempt) Date: Wed, 27 Jun 2012 10:21:30 -0700 Message-ID: <20120627172130.GD7472@merlins.org> References: <1340188512-5761-1-git-send-email-ablock84@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-btrfs@vger.kernel.org, dave@jikos.cz, hch@infradead.org, linux-fsdevel@vger.kernel.org, chris.mason@fusionio.com, linux-kernel@vger.kernel.org To: Alexander Block Return-path: Content-Disposition: inline In-Reply-To: <1340188512-5761-1-git-send-email-ablock84@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jun 20, 2012 at 12:35:11PM +0200, Alexander Block wrote: > Hello, > > This is the second attempt to bring in cross subvolume reflinks into btrfs. > The first attempt was NAKed due to missing vfs mount checks and a clear > description of what btrfs subvolumes are and probably also why cross > subvolume reflinks are ok in the case of btrfs. This version of the patch > comes from David and is in SUSE kernels since a long time, so it is tested > and working. The patch also does proper vfs mount checks, so cross mount > point reflinks are not possible with this patch. It only allows cross > reflinks between two subvolumes which are in the same mount point. Thank you for bringing this back. This would have saved me a lot of trouble I'm not familiar with the code, but here's a big thumbs up from me. Anyone doing reviews, please consider this :) Thanks, Marc -- "A mouse is a device used to point at the xterm you want to type in" - A.S.R. Microsoft is to operating systems .... .... what McDonalds is to gourmet cooking Home page: http://marc.merlins.org/