From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [rfc 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to
 seq-file
Date: Wed, 4 Jul 2012 12:03:45 +0400
Message-ID: <20120704080345.GD1999@moon>
References: <20120627110116.201735815@openvz.org>
 <20120627110512.485189390@openvz.org>
 <4FF3F2B6.5040909@parallels.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	James Bottomley <jbottomley@parallels.com>
To: Pavel Emelyanov <xemul@parallels.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <4FF3F2B6.5040909@parallels.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Jul 04, 2012 at 11:37:26AM +0400, Pavel Emelyanov wrote:
> >  
> > -static ssize_t proc_fdinfo_read(struct file *file, char __user *buf,
> > -				size_t len, loff_t *ppos)
> > -{
> > -	char tmp[PROC_FDINFO_MAX];
> > -	int err = proc_fd_info(file->f_path.dentry->d_inode, NULL, tmp);
> > -	if (!err)
> > -		err = simple_read_from_buffer(buf, len, ppos, tmp, strlen(tmp));
> > -	return err;
> > -}
> > -
> 
> I believe we can still have the proc_fdinfo_read and proc_fd_link code non-splitted.
> Just push a callback pointer ino the proc_fd_info (as usual -- we an opaque void *argument).

Thanks! Will try.

	Cyrill