From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt Date: Thu, 12 Jul 2012 15:58:08 -0700 Message-ID: <20120712155808.807ec3f5.akpm@linux-foundation.org> References: <1342099688-14894-1-git-send-email-dedekind1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Al Viro , Evgeniy Dushistov , Linux FS Maling List , Linux Kernel Maling List To: Artem Bityutskiy Return-path: In-Reply-To: <1342099688-14894-1-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 12 Jul 2012 16:28:05 +0300 Artem Bityutskiy wrote: > Note, checkpatch.pl complains about these patches, but the complaints are about > the code which is already in UFS, not my code. We really need to fix > checkpatch.pl to be smarter. Just fix them up as you go - the code is already a mixture of "right" and "wrong" (a consequence of a lot of it being "wrong") - we might as well tip it further in the "right" direction.