From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt
Date: Thu, 12 Jul 2012 16:17:07 -0700 [thread overview]
Message-ID: <20120712161707.d5bb6df2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120712160951.74cbb3c1.akpm@linux-foundation.org>
On Thu, 12 Jul 2012 16:09:51 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> > 2. removed 'cancel_delayed_work()' from 'hfsplus_sync_fs()' because it is not
> > enough to just cancel the job, we need to set the work_queued flag to zero
> > as well. I could do this, but it is simpler to just remove this tiny
> > optimization - we do not gain much with it. I caught this bug while doing
> > some more testing.
>
> And lo, when I look at "what was changed", I see that this patchset
> actually does *not* remove the cancel_delayed_work() call. What's up
> with that?
Ah, no. I was looking at the cancel_delayed_work() in hfs_put_super().
next prev parent reply other threads:[~2012-07-12 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 14:26 [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt Artem Bityutskiy
2012-07-12 14:26 ` [PATCHv3 1/4] hfsplus: make hfsplus_sync_fs static Artem Bityutskiy
2012-07-12 14:26 ` [PATCHv3 2/4] hfsplus: amend debugging print Artem Bityutskiy
2012-07-12 14:26 ` [PATCHv3 3/4] hfsplus: remove useless check Artem Bityutskiy
2012-07-12 14:26 ` [PATCHv3 4/4] hfsplus: get rid of write_super Artem Bityutskiy
2012-07-12 23:09 ` [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt Andrew Morton
2012-07-12 23:17 ` Andrew Morton [this message]
2012-07-13 5:41 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712161707.d5bb6df2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).