From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt
Date: Thu, 12 Jul 2012 16:17:07 -0700
Message-ID: <20120712161707.d5bb6df2.akpm@linux-foundation.org>
References: <1342103191-17406-1-git-send-email-dedekind1@gmail.com>
	<20120712160951.74cbb3c1.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20120712160951.74cbb3c1.akpm@linux-foundation.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, 12 Jul 2012 16:09:51 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> > 2. removed 'cancel_delayed_work()' from 'hfsplus_sync_fs()' because it is not
> >    enough to just cancel the job, we need to set the work_queued flag to zero
> >    as well. I could do this, but it is simpler to just remove this tiny
> >    optimization - we do not gain much with it. I caught this bug while doing
> >    some more testing.
> 
> And lo, when I look at "what was changed", I see that this patchset
> actually does *not* remove the cancel_delayed_work() call.  What's up
> with that?

Ah, no.  I was looking at the cancel_delayed_work() in hfs_put_super().