From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt Date: Thu, 12 Jul 2012 22:45:38 -0700 Message-ID: <20120712224538.31cb1e18.akpm@linux-foundation.org> References: <1342099688-14894-1-git-send-email-dedekind1@gmail.com> <20120712155808.807ec3f5.akpm@linux-foundation.org> <1342157684.23418.6.camel@brekeke> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Al Viro , Evgeniy Dushistov , Linux FS Maling List , Linux Kernel Maling List To: dedekind1@gmail.com Return-path: In-Reply-To: <1342157684.23418.6.camel@brekeke> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 13 Jul 2012 08:34:44 +0300 Artem Bityutskiy wrote: > On Thu, 2012-07-12 at 15:58 -0700, Andrew Morton wrote: > > Just fix them up as you go - the code is already a mixture of "right" > > and "wrong" (a consequence of a lot of it being "wrong") - we might as > > well tip it further in the "right" direction. > > Yeah, but I'd say 80% of it has its own "wrong" coding style, so fixing > it is a separate patch-set. Simply because when I partially fix it, > there are almost always context lines which upset checkpatch.pl, so I > would need to fix it all. I can easily clean it up a bit separately, > just let me know if you want me to do this. checkpatch does not report on context lines - only on added lines.