From: Andrew Morton <akpm@linux-foundation.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Alex Kelly <alex.page.kelly@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex <eshink@gmail.com>
Subject: Re: [PATCH 1/2] Moved core dump functionality into its own file
Date: Fri, 13 Jul 2012 15:02:46 -0700 [thread overview]
Message-ID: <20120713150246.c058e7d3.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAM_iQpWk7nekZoi5i6yg6Q3hA6Sa1HG2SPjPJ=HFD3cPdbVW9w@mail.gmail.com>
On Tue, 3 Jul 2012 12:53:34 +0800
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@gmail.com> wrote:
> > From: Alex <eshink@gmail.com>
> >
> > This was done in preparation for making core dump functionality optional.
> >
> > The variable "suid_dumpable" and associated functions are left in fs/exec.c
> > because they're used elsewhere, such as in ptrace.
> >
> > Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
> Looks good to me:
Me too, but the first patch conflicts somewhat with a few pending
changes in linux-next. I could fix them up, but would prefer that the
result be tested. Alex, could you please redo the patches against
linux-next or mmotm?
Also, the patch titles could be improved. I suggest
coredump: move core dump functionality into its own file
coredump: make core dump functionality optional
Documentation/SubmittingPatches section 15 describes the thinking here.
Thanks.
next prev parent reply other threads:[~2012-07-13 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 0:38 [PATCH 1/2] Moved core dump functionality into its own file Alex Kelly
2012-07-03 0:38 ` [PATCH 2/2] Made core dump functionality optional Alex Kelly
2012-07-03 4:55 ` Cong Wang
2012-07-03 5:09 ` Josh Triplett
[not found] ` <CAH08tp_5CNnK68G4BpZ+d_V9OMwEt8hC_pbtNovgSCTnGYd0hg@mail.gmail.com>
2012-07-13 3:22 ` Cong Wang
2012-07-03 4:53 ` [PATCH 1/2] Moved core dump functionality into its own file Cong Wang
2012-07-13 22:02 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-01 2:23 Alex Kelly
2012-08-01 21:54 ` Andrew Morton
2012-08-03 21:03 Alex Kelly
2012-08-04 6:43 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713150246.c058e7d3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alex.page.kelly@gmail.com \
--cc=eshink@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).