From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] Moved core dump functionality into its own file
Date: Fri, 13 Jul 2012 15:02:46 -0700
Message-ID: <20120713150246.c058e7d3.akpm@linux-foundation.org>
References: <1341275894-9737-1-git-send-email-alex.page.kelly@gmail.com>
	<CAM_iQpWk7nekZoi5i6yg6Q3hA6Sa1HG2SPjPJ=HFD3cPdbVW9w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Alex Kelly <alex.page.kelly@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alex <eshink@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:55902 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751552Ab2GMWCs (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 13 Jul 2012 18:02:48 -0400
In-Reply-To: <CAM_iQpWk7nekZoi5i6yg6Q3hA6Sa1HG2SPjPJ=HFD3cPdbVW9w@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 3 Jul 2012 12:53:34 +0800
Cong Wang <xiyou.wangcong@gmail.com> wrote:

> On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@gmail.com> wrote:
> > From: Alex <eshink@gmail.com>
> >
> > This was done in preparation for making core dump functionality optional.
> >
> > The variable "suid_dumpable" and associated functions are left in fs/exec.c
> > because they're used elsewhere, such as in ptrace.
> >
> > Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> 
> Looks good to me:

Me too, but the first patch conflicts somewhat with a few pending
changes in linux-next.  I could fix them up, but would prefer that the
result be tested.  Alex, could you please redo the patches against
linux-next or mmotm?

Also, the patch titles could be improved.  I suggest

	coredump: move core dump functionality into its own file
	coredump: make core dump functionality optional

Documentation/SubmittingPatches section 15 describes the thinking here.

Thanks.