* [patch] VFS: copy_tree() returns an error pointer now
@ 2012-07-04 7:39 Dan Carpenter
2012-07-04 9:45 ` David Howells
2012-07-14 12:10 ` Al Viro
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-07-04 7:39 UTC (permalink / raw)
To: David Howells; +Cc: Alexander Viro, linux-fsdevel, kernel-janitors
We recently changed copy_tree() to return an error pointer in
d196d8d327 ('VFS: Make clone_mnt()/copy_tree()/collect_mounts() return
errors'). This call needs to be updated as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/namespace.c b/fs/namespace.c
index 8583bfe..c53d338 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1314,7 +1314,9 @@ struct vfsmount *collect_mounts(struct path *path)
tree = copy_tree(real_mount(path->mnt), path->dentry,
CL_COPY_ALL | CL_PRIVATE);
up_write(&namespace_sem);
- return tree ? &tree->mnt : NULL;
+ if (IS_ERR(tree))
+ return NULL;
+ return &tree->mnt;
}
void drop_collected_mounts(struct vfsmount *mnt)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] VFS: copy_tree() returns an error pointer now
2012-07-04 7:39 [patch] VFS: copy_tree() returns an error pointer now Dan Carpenter
@ 2012-07-04 9:45 ` David Howells
2012-07-14 12:10 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2012-07-04 9:45 UTC (permalink / raw)
To: Dan Carpenter; +Cc: dhowells, Alexander Viro, linux-fsdevel, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We recently changed copy_tree() to return an error pointer in
> d196d8d327 ('VFS: Make clone_mnt()/copy_tree()/collect_mounts() return
> errors'). This call needs to be updated as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] VFS: copy_tree() returns an error pointer now
2012-07-04 7:39 [patch] VFS: copy_tree() returns an error pointer now Dan Carpenter
2012-07-04 9:45 ` David Howells
@ 2012-07-14 12:10 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2012-07-14 12:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Howells, linux-fsdevel, kernel-janitors
On Wed, Jul 04, 2012 at 10:39:45AM +0300, Dan Carpenter wrote:
> We recently changed copy_tree() to return an error pointer in
> d196d8d327 ('VFS: Make clone_mnt()/copy_tree()/collect_mounts() return
> errors'). This call needs to be updated as well.
Folded.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-14 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-04 7:39 [patch] VFS: copy_tree() returns an error pointer now Dan Carpenter
2012-07-04 9:45 ` David Howells
2012-07-14 12:10 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).