From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <jbottomley@parallels.com>,
Matthew Helsley <matt.helsley@gmail.com>
Subject: Re: [patch 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file
Date: Thu, 26 Jul 2012 14:49:29 +0400 [thread overview]
Message-ID: <20120726104929.GC26471@moon> (raw)
In-Reply-To: <50111F36.6000407@parallels.com>
On Thu, Jul 26, 2012 at 02:43:02PM +0400, Pavel Emelyanov wrote:
> On 07/25/2012 01:47 PM, Cyrill Gorcunov wrote:
> > This patch converts /proc/pid/fdinfo/ handling routines to seq-file which
> > is needed to extend seq operations and plug in auxiliary fdinfo provides
> > from subsystems like eventfd/eventpoll/fsnotify.
> >
> > Note the proc_fd_link no longer call for proc_fd_info, simply because
> > proc_fd_info is converted to seq_fdinfo_open (which is seq-file open()
> > prototype), moreover in further patches I need to provide two seq_fdinfo_open
> > variants -- one with CONFIG_CHECKPOINT_RESTORE and one without this
> > symbol. All in one -- this will look more messy then.
>
> This is something I'm really not happy with :( After the set applied we will
> have one former proc_fd_info being splitted into 3 (three!) functions doing
> the same (with flavors).
>
> For me it's better to fix this, otherwise conversion to seq-file looks OK.
OK, thanks for review! I'll try to fix it up.
Cyrill
next prev parent reply other threads:[~2012-07-26 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 9:47 [patch 0/7] procfs fdinfo extension, new round Cyrill Gorcunov
2012-07-25 9:47 ` [patch 1/7] procfs: Move /proc/pid/fd[info] handling code to fd.[ch] Cyrill Gorcunov
2012-07-25 9:47 ` [patch 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file Cyrill Gorcunov
2012-07-26 10:43 ` Pavel Emelyanov
2012-07-26 10:49 ` Cyrill Gorcunov [this message]
2012-07-25 9:47 ` [patch 3/7] procfs: Add ability to plug in auxiliary fdinfo providers Cyrill Gorcunov
2012-07-27 3:48 ` Pavel Emelyanov
2012-07-27 6:00 ` Cyrill Gorcunov
2012-07-27 6:08 ` Pavel Emelyanov
2012-07-27 6:23 ` Cyrill Gorcunov
2012-07-25 9:47 ` [patch 4/7] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-07-25 9:47 ` [patch 5/7] fs, epoll: Add procfs fdinfo helper v2 Cyrill Gorcunov
2012-07-25 9:47 ` [patch 6/7] fs, exportfs: Add export_encode_inode_fh helper Cyrill Gorcunov
2012-07-25 9:47 ` [patch 7/7] fs, notify: Add procfs fdinfo helper v3 Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726104929.GC26471@moon \
--to=gorcunov@openvz.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jbottomley@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.helsley@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).