linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [vfs:fsfreeze] umount BUG: sleeping function called from invalid context
Date: Tue, 31 Jul 2012 17:13:26 +0800	[thread overview]
Message-ID: <20120731091326.GA15095@localhost> (raw)
In-Reply-To: <20120731085815.GF6481@ZenIV.linux.org.uk>

On Tue, Jul 31, 2012 at 09:58:15AM +0100, Al Viro wrote:
> On Tue, Jul 31, 2012 at 04:38:39PM +0800, Fengguang Wu wrote:
> > Hi Jan,
> > 
> > Here is another warning for the fs freeze series.
> > 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fsfreeze
> > head:   7aff72a61f45337d83ab2b7fb16d7b542db16ad8
> > commit: bc875c078f72993e6c44925cdedef5a304ca7429 [37/51] fs: Improve filesystem freezing handling
> > 
> > The warning shows up reliably since commit bc875c0. The 2nd commit
> > 51205f9 triggers the same warning as the previous email.
> 
> That one is fixed in the end of #fsfreeze (for testing purposes only) and then the right
> way in #for-next (by making percpu_list_lock a  spinlock).

Ah sorry. It seems that you quickly pushed the fix

        commit c91dc212879946b8e542773394cb56e6e3c6e1ae
        CommitDate: Tue Jul 31 01:57:53 2012 +0400

            [ewww][testing-only] deal with b0rken use of percpu_counter_destroy() under spinlock

while I'm still testing the slightly old head:

        commit 7aff72a61f45337d83ab2b7fb16d7b542db16ad8
        CommitDate: Tue Jul 31 01:21:32 2012 +0400

            Documentation: Correct s_umount state for freeze_fs/unfreeze_fs

Thanks,
Fengguang

  reply	other threads:[~2012-07-31  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  8:38 [vfs:fsfreeze] umount BUG: sleeping function called from invalid context Fengguang Wu
2012-07-31  8:58 ` Al Viro
2012-07-31  9:13   ` Fengguang Wu [this message]
2012-07-31  9:33     ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120731091326.GA15095@localhost \
    --to=fengguang.wu@intel.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).