From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tino Reichardt Subject: Re: [Jfs-discussion] [PATCH] fs/jfs: TRIM support for JFS Filesystem Date: Wed, 1 Aug 2012 22:08:29 +0200 Message-ID: <20120801200829.GA30608@mcmilk.de> References: <20120726213219.GA28330@mcmilk.de> <20120728110805.GA690@mcmilk.de> <50185916.7010705@oracle.com> <20120801192934.GB19139@mcmilk.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, jfs-discussion@lists.sourceforge.net Return-path: Received: from lola.svc-box.de ([82.149.231.63]:34819 "EHLO lola.svc-box.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755950Ab2HAUIc (ORCPT ); Wed, 1 Aug 2012 16:08:32 -0400 Content-Disposition: inline In-Reply-To: <20120801192934.GB19139@mcmilk.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: * Tino Reichardt wrote: > * Dave Kleikamp wrote: > > On 07/28/2012 06:08 AM, Tino Reichardt wrote: > > > * Tino Reichardt wrote: > > >> > This patch adds support for the two linux interfaces of the discard/TRIM > > >> > command for SSD devices and sparse/thinly-provisioned LUNs. > > > Fixed a problem when setting minlen in jfs_ioc_trim(). Oops, setting minlen in jfs_ioc_trim() was again wrong :/ I changed this if (minlen < 0) minlen = 1; to this: if (minlen <= 0) minlen = 1; This is important, since fstrim() sets it to zero. Fully working patch is located here: http://www.mcmilk.de/projects/jfs-trim/linux-tree/jfs-trim-2012-08-01_v2.diff Signed-off-by: Tino Reichardt -- regards, TR