From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Date: Thu, 16 Aug 2012 19:09:32 +0400 Message-ID: <20120816150932.GD13066@moon> References: <20120815092116.700948346@openvz.org> <20120815092409.591460800@openvz.org> <20120815204546.GC25062@fieldses.org> <20120815210237.GF25421@moon> <20120815220622.GA28054@fieldses.org> <20120816062448.GA32081@moon> <20120816123814.GD1209@moon> <20120816124703.GE28054@fieldses.org> <20120816145700.GB13382@moon> <20120816150542.GV23464@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "J. Bruce Fields" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexey Dobriyan , Andrew Morton , Pavel Emelyanov , James Bottomley , Matthew Helsley To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20120816150542.GV23464@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Aug 16, 2012 at 04:05:42PM +0100, Al Viro wrote: > On Thu, Aug 16, 2012 at 06:57:00PM +0400, Cyrill Gorcunov wrote: > > > Guys, would the patch below be more-less acceptible? > > In inotify I think we could pass "parent" as NULL and use general > > encode engine then (ie it will look like someone called for > > name_to_handle_at on inotify target). > > Wait. What the hell are you going to do with those afterwards? > Again, there's a shitload of filesystems that cannot be exported > over NFS, exactly because there's no way to implement sanely > working fhandles. And idiotify is allowed for all of them. Yes, just recognized that, Al. There will be no way to restore them from fhandle provided via fdinfo. /me scratching the head... > You *can't* decode anything fhandle-like on e.g. sysfs. Or procfs. > Or configfs. Or any network filesystem (I'd argue that we should simply > ban idiotify on those, but good luck doing that). You *can* do that > for FAT derivatives, but only if you have parent directory when creating > that sucker. Cyrill