From: Theodore Ts'o <tytso@mit.edu>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Yongqiang Yang <xiaoqiangnk@gmail.com>,
Allison Henderson <achender@linux.vnet.ibm.com>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [RFC][PATCH 3/8 v2] ext4: initialize extent status tree
Date: Wed, 19 Sep 2012 15:05:41 -0400 [thread overview]
Message-ID: <20120919190541.GE28470@thunk.org> (raw)
In-Reply-To: <1345615545-26133-4-git-send-email-wenqing.lz@taobao.com>
On Wed, Aug 22, 2012 at 02:05:40PM +0800, Zheng Liu wrote:
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 3e0851e..353b1fd 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -944,6 +944,7 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
> memset(&ei->i_cached_extent, 0, sizeof(struct ext4_ext_cache));
> INIT_LIST_HEAD(&ei->i_prealloc_list);
> spin_lock_init(&ei->i_prealloc_lock);
> + ext4_es_init_tree(&ei->i_es_tree);
> ei->i_reserved_data_blocks = 0;
> ei->i_reserved_meta_blocks = 0;
> ei->i_allocated_meta_blocks = 0;
This patch hunk immediately me ask, "so when does the extent_status
tree get freed?" And I believe the answer is that currently, since it
only tracks delayed extents (and we're not using it for locking
purposes), by the time we have evicted the inode and are ready to call
ext4_clear_inode(), we should have released all of the nodes in the
ext4_es_tree. Is that correct?
If so, we might want to think about adding a sanity check to make sure
that by the time we are done with the inode in ext4_evict_inode()
(after we have forced writeback), the ext4_es_tree is empty. Agreed?
- Ted
next prev parent reply other threads:[~2012-09-19 19:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 6:05 [RFC][PATCH 0/8 v2] ext4: extent status tree (step 1) Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 1/8 v2] ext4: add two structures supporting extent status tree Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 2/8 v2] ext4: add operations on " Zheng Liu
2012-09-19 18:34 ` Theodore Ts'o
2012-09-24 4:25 ` Zheng Liu
2012-09-19 18:41 ` Theodore Ts'o
2012-09-24 3:35 ` Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 3/8 v2] ext4: initialize " Zheng Liu
2012-09-19 18:53 ` Theodore Ts'o
2012-09-19 19:05 ` Theodore Ts'o [this message]
2012-09-24 4:45 ` Zheng Liu
2012-09-25 12:42 ` Zheng Liu
2012-09-25 20:59 ` Theodore Ts'o
2012-09-26 2:09 ` Zheng Liu
2012-09-26 2:47 ` Theodore Ts'o
2012-09-26 3:24 ` Zheng Liu
2012-09-26 3:37 ` Theodore Ts'o
2012-09-26 3:54 ` Zheng Liu
2012-09-26 3:46 ` Theodore Ts'o
2012-09-26 3:59 ` Zheng Liu
2012-09-28 7:27 ` Zheng Liu
2012-09-28 17:42 ` Theodore Ts'o
[not found] ` <CANWLp02F=qDXY_KbhAziPkBe8qGKV6oN3XtSdc5bWOkbDG684g@mail.gmail.com>
2012-09-29 3:07 ` Theodore Ts'o
2012-09-29 13:26 ` Zheng Liu
2012-09-30 14:00 ` Dmitry Monakhov
2012-09-29 13:24 ` Fwd: " Zheng Liu
2012-09-26 8:00 ` Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 4/8 v2] ext4: let ext4 maintain " Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 5/8 v2] ext4: add some tracepoints in " Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 6/8 v2] ext4: reimplement fiemap on " Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 7/8 v2] ext4: reimplement ext4_find_delay_alloc_range " Zheng Liu
2012-08-22 6:05 ` [RFC][PATCH 8/8 v2] ext4: introduce lseek SEEK_DATA/SEEK_HOLE support Zheng Liu
2012-09-20 14:41 ` [RFC][PATCH 0/8 v2] ext4: extent status tree (step 1) Theodore Ts'o
2012-09-21 1:51 ` Zheng Liu
2012-09-21 3:19 ` Yongqiang Yang
2012-09-22 0:02 ` Theodore Ts'o
2012-09-24 3:16 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919190541.GE28470@thunk.org \
--to=tytso@mit.edu \
--cc=achender@linux.vnet.ibm.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).